#11: stored function for sale undo transaction

brmbar3/brmbar/Shop.py

@@ -68,14 +68,20 @@ class Shop:
 
     def undo_sale(self, item, user, amount = 1):
         # Undo sale; rarely needed
-        (buy, sell) = item.currency.rates(self.currency)
+        #(buy, sell) = item.currency.rates(self.currency)
-        cost = amount * sell
+        #cost = amount * sell
-        profit = amount * (sell - buy)
+        #profit = amount * (sell - buy)
+
+        #transaction = self._transaction(responsible = user, description = "BrmBar sale UNDO of {}x {} to {}".format(amount, item.name, user.name))
+        #item.debit(transaction, amount, user.name + " (sale undo)")
+        #user.credit(transaction, cost, item.name + " (sale undo)")
+        #self.profits.credit(transaction, profit, "Margin repaid on " + item.name)
+        # Call the stored procedure for undoing a sale
+        cost = self.db.execute_and_fetch(
+            "SELECT public.undo_sale_of_item(%s,  %s, %s, %s)",
+            [item.id, amount, user.id, user.currency.id, f"BrmBar sale UNDO of {amount}x {item.name} to {user.name}"]
+        )[0]#[0]
 
-        transaction = self._transaction(responsible = user, description = "BrmBar sale UNDO of {}x {} to {}".format(amount, item.name, user.name))
-        item.debit(transaction, amount, user.name + " (sale undo)")
-        user.credit(transaction, cost, item.name + " (sale undo)")
-        self.profits.credit(transaction, profit, "Margin repaid on " + item.name)
         self.db.commit()
 
         return cost

brmbar3/schema/0011-shop-undo-sale.sql

@@ -0,0 +1,102 @@
+--
+-- 0011-shop-undo-sale.sql
+--
+-- #11 - stored function for sale undo transaction
+--
+-- ISC License
+--
+-- Copyright 2023-2025 Brmlab, z.s.
+-- TMA <tma+hs@jikos.cz>
+--
+-- Permission to use, copy, modify, and/or distribute this software
+-- for any purpose with or without fee is hereby granted, provided
+-- that the above copyright notice and this permission notice appear
+-- in all copies.
+--
+-- THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL
+-- WARRANTIES WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED
+-- WARRANTIES OF MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE
+-- AUTHOR BE LIABLE FOR ANY SPECIAL, DIRECT, INDIRECT, OR
+-- CONSEQUENTIAL DAMAGES OR ANY DAMAGES WHATSOEVER RESULTING FROM LOSS
+-- OF USE, DATA OR PROFITS, WHETHER IN AN ACTION OF CONTRACT,
+-- NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF OR IN
+-- CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
+--
+
+-- To require fully-qualified names
+SELECT pg_catalog.set_config('search_path', '', false);
+
+DO $upgrade_block$
+BEGIN
+
+IF brmbar_privileged.has_exact_schema_version(10) THEN
+
+CREATE OR REPLACE FUNCTION brmbar_privileged.create_transaction(
+	i_responsible_id public.accounts.id%TYPE,
+	i_description public.transactions.description%TYPE
+) RETURNS public.transactions.id%TYPE AS $$
+DECLARE
+	new_transaction_id public.transactions%TYPE;
+BEGIN
+	-- Create a new transaction
+	INSERT INTO public.transactions (responsible, description)
+	VALUES (i_responsible_id, i_description)
+	RETURNING id INTO new_transaction_id;
+	-- Return the new transaction ID
+	RETURN new_transaction_id;
+END;
+$$ LANGUAGE plpgsql;
+
+CREATE OR REPLACE FUNCTION public.undo_sale_of_item(
+	i_item_id public.accounts.id%TYPE,
+	i_amount INTEGER,
+	i_user_id public.accounts.id%TYPE,
+	i_target_currency_id public.currencies.id%TYPE,
+	i_description TEXT
+) RETURNS NUMERIC
+LANGUAGE plpgsql
+AS $$
+DECLARE
+	v_buy_rate NUMERIC;
+	v_sell_rate NUMERIC;
+	v_cost NUMERIC;
+	v_profit NUMERIC;
+	v_transaction_id public.transactions.id%TYPE;
+BEGIN
+	-- Get the buy and sell rates from the stored functions
+	v_buy_rate := public.find_buy_rate(i_item_id, i_target_currency_id);
+	v_sell_rate := public.find_sell_rate(i_item_id, i_target_currency_id);
+
+	-- Calculate cost and profit
+	v_cost := i_amount * v_sell_rate;
+	v_profit := i_amount * (v_sell_rate - v_buy_rate);
+
+	-- Create a new transaction
+	v_transaction_id := brmbar_privileged.create_transaction(i_user_id, i_description);
+
+	-- the item (decrease stock)
+	INSERT INTO public.transaction_splits (transaction, side, account, amount, memo)
+	VALUES (i_transaction_id, 'debit', i_item_id, i_amount,
+	(SELECT "name" || ' (sale undo)' FROM public.accounts WHERE id = i_user_id));
+
+	-- the user
+	INSERT INTO public.transaction_splits (transaction, side, account, amount, memo)
+	VALUES (i_transaction_id, 'credit', i_user_id, v_cost,
+	(SELECT "name" || ' (sale undo)' FROM public.accounts WHERE id = i_item_id));
+
+	-- the profit
+	INSERT INTO public.transaction_splits (transaction, side, account, amount, memo)
+	VALUES (i_transaction_id, 'credit', (SELECT account_id FROM accounts WHERE name = 'BrmBar Profits'), v_profit, (SELECT 'Margin repaid on ' || "name" FROM public.accounts WHERE id = i_item_id));
+
+	-- Return the cost
+	RETURN v_cost;
+END;
+$$;
+
+PERFORM brmbar_privileged.upgrade_schema_version_to(11);
+END IF;
+
+END;
+$upgrade_block$;
+
+-- vim: set ft=plsql :