brmlab/brmelect
4
0
Fork 0
mirror of https://github.com/pasky/brmelect.git synced 2025-06-08 01:54:03 +02:00
Code Issues Projects Releases Packages Wiki Activity

web-ballot.pl: Refactor the form to be order-oriented, not people-oriented, and use dropdowns

Browse source
This commit is contained in:
Petr Baudis 2014-10-13 19:51:21 +02:00
parent 7bc21433b7
commit 9fd23805c5
1 changed files with 20 additions and 38 deletions
Download patch file Download diff file Expand all files Collapse all files

58
web-ballot.pl
View file

@ -71,54 +71,35 @@ if ($q->param('go')) {
my $votestr; my $votestr;
unless ($q->param('invalid')) { unless ($q->param('invalid')) {
my @indices; my @indices;
for (0..@names) {
$indices[$_] = '';
}
# XXX: We ignore $indices[0] for simplicity, we start indexing from 1 here! # XXX: We ignore $indices[0] for simplicity, we start indexing from 1 here!
my %prefs; my %prefs;
my $n_set = 0; my $n_set = 0;
for my $name (@names) { my $over = 0;
my $pref = $q->param($name); for my $i (1..@names) {
next if (not defined $pref or $pref eq ''); my $pref = $q->param($i);
if (length $pref > 5) { if (not defined $pref or $pref eq '') {
print qq#<p class="error">Length of preference for $name is # . (length $pref) . qq# which is just waaay too much. Please go back and try again.</p>#; $over = 1;
next;
}
if ($over > 0) {
print qq#<p class="error">Number $i has a candidate but some higher preference does not, which is not permitted. Please go back and try again.</p>#;
exit; exit;
} }
$pref =~ s/\s*//g; if (not grep { $_ eq $pref } @names) {
unless ($pref =~ /^\d+$/) { print qq#<p class="error">Number $i has an unknown candidate $pref, are you trolling? Please go back and try again.</p>#;
$pref =~ s/[^\w\d.,-]//g;
print qq#<p class="error">Preference for $name is $pref, which is not a number. Please go back and try again.</p>#;
exit; exit;
} }
if ($pref < 1 or $pref > @names) { if (exists $prefs{$pref}) {
print qq#<p class="error">Preference for $name is $pref, which is out of the sensible range 1..# . (scalar @names) . qq#. Please go back and try again.</p>#; print qq#<p class="error">Candidate $pref is selected as both number $prefs{$pref} and $i, this is not permitted. Please go back and try again.</p>#;
exit; exit;
} }
if ($indices[$pref] ne '') { $prefs{$pref} = $i;
print qq#<p class="error">Preference for $name is $pref, but this number is already also used for the candidate '$indices[$pref]'. Please go back and try again.</p>#; $indices[$i] = $pref;
exit;
}
$indices[$pref] = $name;
$prefs{$name} = $pref;
$n_set++;
} }
for my $i (1..$n_set) { if (not keys %prefs) {
if ($indices[$i] eq '') { print qq#<p class="error">You must assign a preference to at least one candidate. Please go back and try again.</p>#;
print qq#<p class="error">Number $i was left unused, which is not permitted. Please go back and try again.</p>#;
exit;
}
}
for my $i (($n_set+1)..$#indices) {
if ($indices[$i] ne '') {
print qq#<p class="error">Number $i was used out of uninterrupted natural number sequence, which is not permitted. Please go back and try again.</p>#;
exit;
}
}
if ($indices[1] eq '') {
print qq#<p class="error">You must assign a preference (1) to at least one candidate. Please go back and try again.</p>#;
exit; exit;
} }
@ -146,8 +127,9 @@ print <<EOT;
<ul> <ul>
EOT EOT
for my $name (@names) { for my $i (1..@names) {
print qq#<li><input type="text" name="$name" size="3" /> $name</li>\n#; my $options = join('', map { qq#<option value="$_">$_</option># } @names);
print qq#<li>$i. <select name="$i"><option value="" selected="1">- - -</option>$options</select></li>\n#;
} }
print <<EOT; print <<EOT;