Safe passing of subprocess arguments - always.

src/mailman.scm

@@ -73,11 +73,10 @@
 
  ;; Mailman-specific process output lines capture
  (define (get-mailman-output-lines bin . args)
-   (get-process-output-lines
+   (apply
-    (string-intersperse
+    get-process-output-lines
-     (cons (mailman-bin bin)
+    (mailman-bin bin)
-	   args)
+    args))
-     " ")))
     
  ;; Returns the list of available lists
  (define (list-mailman-lists)

src/util-io.scm

@@ -58,8 +58,8 @@
 
  ;; Very simple shell command wrapper that returns lines produced by
  ;; given command. Dangerous - performs no argument escaping!
- (define (get-process-output-lines cmd)
+ (define (get-process-output-lines cmd . args)
-   (let-values (((stdout stdin pid stderr) (process* cmd)))
+   (let-values (((stdout stdin pid stderr) (process* cmd args)))
      (close-output-port stdin)
      (let ((result (read-lines stdout)))
        (let-values (((a b c) (process-wait pid)))

src/web-static.scm

@@ -71,11 +71,12 @@
        (lambda ()
 	 (let loop ((lines
 		     (get-process-output-lines
-		      (sprintf "git -C \"~A\" log -p -- \"~A\""
+		      "git"
-			       (string-translate* (*members-directory*)
+		      "-C" (*members-directory*)
-						  '(("\"" . "\\\"")))
+		      "log"
-			       (brmember-file-name mr)
+		      "-p"
-			       ))))
+		      "--"
+		      (brmember-file-name mr))))
 	   (when (not (null? lines))
 	     (print (car lines))
 	     (loop (cdr lines))))))